Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EV-3840] Add networkpolicies to policy rec clusterrole #2714

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[EV-3840] Add networkpolicies to policy rec clusterrole #2714

merged 1 commit into from
Jul 7, 2023

Conversation

dimitri-nicolo
Copy link
Contributor

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@dimitri-nicolo dimitri-nicolo requested a review from a team as a code owner July 5, 2023 02:34
@marvin-tigera marvin-tigera added this to the v1.31.0 milestone Jul 5, 2023
rene-dekker
rene-dekker approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimitri-nicolo dimitri-nicolo mentioned this pull request Jul 7, 2023
Merged
5 tasks
@rene-dekker
Copy link
Member

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit bed828b into tigera:master Jul 7, 2023
@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

@dimitri-nicolo dimitri-nicolo deleted the dimitri-EV-3840 branch July 7, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene-dekker rene-dekker rene-dekker approved these changes

Assignees
No one assigned
Labels
delete-branch docs-pr-required merge-when-ready release-note-required
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dimitri-nicolo @rene-dekker @marvin-tigera